Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access DB_SCHEMES through cls rather than Env in db_url_config. #414

Merged
merged 1 commit into from Sep 20, 2022
Merged

Access DB_SCHEMES through cls rather than Env in db_url_config. #414

merged 1 commit into from Sep 20, 2022

Conversation

fizyk
Copy link
Contributor

@fizyk fizyk commented Aug 22, 2022 

This will allow to inherit Env class and extend DB_SCHEMES with minimal changes required.

(ie. Add new scheme, use connection pooling library, etc)

@fizyk
Access DB_SCHEMES through cls rather than Env in db_url_config.
b30e56d 
    This will allow to inherit Env class and extend DB_SCHEMES with minimal changes required.

    (ie. Add new scheme, use connection pooling library, etc)
@sergeyklay sergeyklay self-assigned this Sep 20, 2022
@sergeyklay sergeyklay added the enhancement New feature or request label Sep 20, 2022
@sergeyklay sergeyklay self-requested a review September 20, 2022 07:32
sergeyklay
sergeyklay approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.466% when pulling b30e56d on fizyk:allow-override_db_schemes_children into 86716ac on joke2k:develop.

@sergeyklay sergeyklay added good first issue Good for newcomers hacktoberfest-accepted See https://hacktoberfest.digitalocean.com/ for participants details labels Sep 20, 2022
@sergeyklay sergeyklay merged commit c2b35db into joke2k:develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees

@sergeyklay sergeyklay

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted See https://hacktoberfest.digitalocean.com/ for participants details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fizyk @coveralls @sergeyklay