Use PyPI Trusted Publisher for releases #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
May 15, 2023
There was a problem hiding this comment.
Also https://scikit-hep.org/developer/gha_pure#distribution-pure-python-wheels :)
Remember to set up on PyPI.
|
Did you define the pypi environment in repository settings? |
|
It will create it the first time it’s used. Though if you want to control who can release, you should create or edit it. :) |
Or put a cooldown timer, for example... |
webknjaz
reviewed
May 16, 2023
| @@ -27,6 +27,9 @@ jobs: | |||
| needs: [dist] | |||
| runs-on: ubuntu-latest | |||
| if: github.event_name == 'release' && github.event.action == 'published' | |||
| environment: pypi | |||
There was a problem hiding this comment.
A nicer syntax could be
Suggested change
| environment: pypi | |
| environment: | |
| name: pypi | |
| url: https://pypi.org/p/cibuildwheel |
which makes the URL show up in the workflow graph UI (and some other places). I like rendering the versioned URL even, when I have a version variable available...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copying scikit-build/scikit-build-core#306
And following https://docs.pypi.org/trusted-publishers/adding-a-publisher/