Add create_args suboption to CIBW_CONTAINER_ENGINE #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerick
commented
May 15, 2023
joerick
commented
May 15, 2023
|
I don't expect this to change much, but I'll mark as draft until I can get the tests to pass! |
|
Travis failure looks unrelated. Ready for review! |
henryiii
approved these changes
May 16, 2023
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1384
Adds the ability to give additional command line arguments to the container engine (docker or podman). These are supplied inside the existing CIBW_CONTAINER_ENGINE option in a backward-compatible format so we don't increase the options surface area, and because, in theory at least, these options could vary in future depending on the container engine used.