Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook sent twice on the newest version #676

Closed
omer2500 opened this issue Mar 31, 2024 · 3 comments
Closed

Webhook sent twice on the newest version #676

omer2500 opened this issue Mar 31, 2024 · 3 comments

Comments

@omer2500
Copy link

Hi,

We have a job that sends a webhook on a workflow
A couple of hours ago it started to send the webhook twice each time it ran.

we are using the tag master and I saw that a new version was released 3 days ago

what I see is that we have another step called Post webhook that sends the webhook again and have the same logs

on 2.3.2 it doesn't happen

I'm attaching pictures to show the issue

latest version:
image

2.3.2:

image

is this intentional? am I missing some new configuration ? or is this a bug?

Thanks!

@joelwmale
Copy link
Owner

joelwmale commented Mar 31, 2024

@omer2500 Can you send me the workflow file and how you've set up this step?

Testing this on the master version (prior to release, using develop) never sent the webhook twice.

P.s: It does look like you have set up a second step. What is the difference between webhook and post webhook steps?

@omer2500
Copy link
Author

omer2500 commented Mar 31, 2024

Hi, @joelwmale
I have no step called Post webhook,
the log is the same except It mentions its a cleanup job but right after that log I see the log that indicated webhook sent

just to mention I'm running on self-hosted runners on aws ,
so you might need to adjust the runs-on property

just play with the tag of the version from master to 2.3.2 and put a working webhook url
and check the steps that were executed

this is the workflow I used to test:

name: test
on:
    pull_request:
        branches:
            - master
jobs:
    send_bq_data:
        runs-on: self-hosted
        steps:
          - name: Webhook
            uses: joelwmale/webhook-action@master
            with:
              url: https://example.com/webhook
              headers: '{"Content-Type": "application/json"}'
              body: '{"message": "Hello, World!"}'

@joelwmale joelwmale mentioned this issue Mar 31, 2024
@joelwmale
Copy link
Owner

Hey @omer2500 apologies, seems like it was an oversight on my behalf in the action configuration file. Try again using the latest master (v2.4.1). Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants