Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub deprecating support for actions using node16 #668

Closed
caquino opened this issue Feb 15, 2024 · 4 comments
Closed

GitHub deprecating support for actions using node16 #668

caquino opened this issue Feb 15, 2024 · 4 comments

Comments

@caquino
Copy link

caquino commented Feb 15, 2024

Hi,

As part of some of my workflows, I use this action and I'm seeing warnings from GitHub about the deprecation of node16 support on actions.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: joelwmale/webhook-action@2.3.2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I am more than happy to submit a PR with the changes, but I see that the last update was 2 years ago so before doing the work I would like to ask if this is something that is welcome or if this action should be considered deprecated and I should look for a replacement/fork for this one.

Thanks in advance!

@joelwmale
Copy link
Owner

Hi @caquino. Always happy to take a PR to fix this up.

Project is not dead, just don't have any more features to add, so very little work needed to maintain.

Thanks!

@Gargaj
Copy link

Gargaj commented Mar 23, 2024

Would it need more than updating https://github.com/joelwmale/webhook-action/blob/develop/action.yml#L24 from node16 to node20?

@joelwmale
Copy link
Owner

@Gargaj I'll take a look at it in the next few hours and see if I can get it fixed for you.

This was referenced Mar 28, 2024
@joelwmale
Copy link
Owner

@Gargaj this is all fixed and merged into master, at version 2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants