Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Quick Edit Mode with mouse support on conhost #964

Closed
jvalkeal opened this issue Apr 16, 2024 · 0 comments · Fixed by #965
Closed

Disable Quick Edit Mode with mouse support on conhost #964

jvalkeal opened this issue Apr 16, 2024 · 0 comments · Fixed by #965
Milestone

Comments

@jvalkeal
Copy link
Contributor

This is a windows conhost(good 'ol plain cmd) related annoyance where mouse events are not sent if Quick Edit Mode is enabled(as it is by default). This is more clearly discussed in https://stackoverflow.com/questions/46795072/how-to-get-mouse-input-inside-a-c-console-program-on-windows-10/46802726#46802726.

We should simply use combination of ENABLE_QUICK_EDIT_MODE and ENABLE_EXTENDED_FLAGS to disable/restore it if mouse is requested via terminals trackMouse function.

jvalkeal added a commit to jvalkeal/jline3 that referenced this issue Apr 17, 2024
- On windows disable quick edit mode if mouse support
  is requested which allows mouse events to
  get propagated automatically.
- There's no explicit revert for this as it seems
  to get done automatically.
- Without this user would need to know that quick edit
  needs to be disabled which is awkward in conhost
  and even more difficult with new windows terminal
  which doesn't even directly expose these settings
  in the UI.
- Fixes jline#964
@gnodet gnodet added this to the 3.26.0 milestone Apr 17, 2024
gnodet pushed a commit that referenced this issue Apr 17, 2024
- On windows disable quick edit mode if mouse support
  is requested which allows mouse events to
  get propagated automatically.
- There's no explicit revert for this as it seems
  to get done automatically.
- Without this user would need to know that quick edit
  needs to be disabled which is awkward in conhost
  and even more difficult with new windows terminal
  which doesn't even directly expose these settings
  in the UI.
- Fixes #964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants