Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v0.7.0, some incompatibilities were introduced in protocompile, due to changes/improvements to its
ErrorWithPos
type, to support reporting a region of code for an error instead of just a single position. So this module'sprotoparse.ErrorWithSourcePos
had to be updated to accommodate that change. That version also depends on a commit ofgoogle.golang.org/protobuf
that has a newer version ofgoogle/protobuf/descriptor.proto
, necessitating some updates of golden output files that correspond todescriptor.proto
. There have also been tweaks to the parser inprotocompile
to make the parser able to return a more complete AST, even in the face of some common kinds of errors. This means some syntax error messages have changed, which required updating some test assertions about errors.