Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to protocompile v0.7.1 #586

Merged
merged 1 commit into from
Dec 7, 2023
Merged

update to protocompile v0.7.1 #586

merged 1 commit into from
Dec 7, 2023

Conversation

jhump
Copy link
Owner

@jhump jhump commented Dec 7, 2023

As of v0.7.0, some incompatibilities were introduced in protocompile, due to changes/improvements to its ErrorWithPos type, to support reporting a region of code for an error instead of just a single position. So this module's protoparse.ErrorWithSourcePos had to be updated to accommodate that change. That version also depends on a commit of google.golang.org/protobuf that has a newer version of google/protobuf/descriptor.proto, necessitating some updates of golden output files that correspond to descriptor.proto. There have also been tweaks to the parser in protocompile to make the parser able to return a more complete AST, even in the face of some common kinds of errors. This means some syntax error messages have changed, which required updating some test assertions about errors.

@jhump jhump merged commit f139a6d into main Dec 7, 2023
5 checks passed
@jhump jhump deleted the jh/update-protocompile branch December 7, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant