Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis-py package requirement to 5.0.2 #753

Closed
NieldSWND opened this issue Mar 1, 2024 · 1 comment
Closed

Update redis-py package requirement to 5.0.2 #753

NieldSWND opened this issue Mar 1, 2024 · 1 comment

Comments

@NieldSWND
Copy link

NieldSWND commented Mar 1, 2024

The redis-py 5.0.1 package had a breaking change in that it made its connection callback methods semi-private, which prevented celery from accessing those methods using their original method names and lead to errors like the one attached. This change was reverted in redis-py version 5.0.2. For more on this, see: redis/redis-py#2980

Would you please increment the redis-py version required by docassemble.webapp package to 5.0.2? Until you do, my only workaround to avoid these errors is to manually adjust the celery module every time I rebuild the Docassemble Docker container so as to reference the adjusted, semi-private connection callback methods in redis-py.

redis-py error.pdf

@jhpyle
Copy link
Owner

jhpyle commented Mar 2, 2024

Sorry about that, I don't test on a redis connection with SSL so this didn't come up in my testing. Thanks for figuring out what the fix was. I upgraded redis to 5.0.2 and also upgraded celery to the latest version, which may help.

@jhpyle jhpyle closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants