Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for require-pragma option (resolves #573) #574

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

yannick-paz
Copy link
Contributor

What changed with this PR:

Added support for the require-pragma option

Example

// Input
/**
 * @prettier
 */
public class Example { private int test=-1;}

// Output
/**
 * @prettier
 */
public class Example {
  private int test = -1;
}
// Input
public class Example { private int test=-1;}

// Output
public class Example { private int test=-1;}

Relative issues or prs:

#573

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2023

CLA assistant check
All committers have signed the CLA.

@clementdessoude
Copy link
Contributor

Hi @yannick-paz ! Thank you for submitting this PR, it is very welcome ! And sorry for the delay in the review :/

It looks great, would it be possible for you to sign the Contributor Licence Agreement ? It is needed for all contributions in any JHipster project.

@yannick-paz
Copy link
Contributor Author

Hey @clementdessoude, thanks for reviewing!
I did sign the CLA but it doesn't seem to be reflected in the PR.
Not sure what I'm missing but if you have a recommended browser or browser settings that I should try (e.g. incognito mode) I'm all ears!

@pascalgrimaud
Copy link
Member

@yannick-paz : it's because you commit with this account https://github.com/livemrgreen so it doesnt match

@yannick-paz
Copy link
Contributor Author

@pascalgrimaud good catch, fixed now :)

@clementdessoude clementdessoude merged commit 3bb0653 into jhipster:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants