Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation warning for annotation attribute overrides in AuthorizedFeignClient #25536

Merged
merged 2 commits into from Mar 19, 2024

Conversation

yhao3
Copy link
Contributor

@yhao3 yhao3 commented Mar 19, 2024


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible
Copy link
Contributor

mraible commented Mar 19, 2024

Can you please provide steps for how to reproduce this problem? A JDL would be nice.

@yhao3
Copy link
Contributor Author

yhao3 commented Mar 19, 2024

Hi @mraible,

Here are the steps to reproduce the issue:

Step 1. Create a project using the following JDL:

JHipster version 8.1.0

application {
  config {
    baseName store
    reactive false
    packageName com.example.store
    applicationType microservice
    authenticationType oauth2
    buildTool maven
    databaseType mongodb
    enableHibernateCache false
    serverPort 8082
    serviceDiscoveryType consul
    feignClient true
  }
  entities Product
}

entity Product {
  title String required
  price BigDecimal required min(0)
}

paginate Product with pagination
service * with serviceClass

microservice Product with store

Step 2. Add the following interface in the client package:

package com.example.store.client;

@AuthorizedFeignClient(name = "demo")
public interface DemoClient {
}

Step 3. Then run the project and you will see the following warning message:

WARN 83460 --- [  restartedMain] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.2. Please annotate the following attributes in @com.example.store.client.AuthorizedFeignClient with appropriate @AliasFor declarations: [path, fallback, url]

@DanielFran DanielFran merged commit a8ba4be into jhipster:main Mar 19, 2024
52 checks passed
@DanielFran
Copy link
Member

Thanks @yhao3 for the contribution

@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants