Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Neo4j reactive implementation #25523

Merged
merged 2 commits into from Mar 18, 2024
Merged

Fix Neo4j reactive implementation #25523

merged 2 commits into from Mar 18, 2024

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Mar 18, 2024

Fixes issue found when testing 8.2. #25259 (comment)


Please make sure the below checklist is followed for Pull Requests.

@mraible
Copy link
Contributor Author

mraible commented Mar 18, 2024

The ms-mf-ng-consul-oauth2-neo4j job is failing with the following error after this change:

Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'postRepository' defined in com.okta.developer.blog.repository.PostRepository defined in @EnableReactiveNeo4jRepositories declared on Neo4jReactiveRepositoriesRegistrar.EnableReactiveNeo4jRepositoriesConfiguration: Repository com.okta.developer.blog.repository.PostRepository implements org.springframework.data.repository.query.QueryByExampleExecutor but ReactiveNeo4jRepositoryFactory does not support Query by Example

I also noticed that the Spring Boot Maven Plugin needs a version specified.

Warning: Some problems were encountered while building the effective model for com.okta.developer.gateway:gateway:jar:8.1.0-git
Warning: 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.springframework.boot:spring-boot-configuration-processor:jar -> duplicate declaration of version (?) @ line 95, column 21
Warning: 'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 321, column 21

@mraible
Copy link
Contributor Author

mraible commented Mar 18, 2024

It looks like the spring-boot-configuration-processor plugin is listed twice in pom.xml too.

Update: Maven warnings are fixed in #25524.

@mshima mshima merged commit bfe83aa into main Mar 18, 2024
56 checks passed
@mshima mshima deleted the neo4j-reactive-fix branch March 18, 2024 19:14
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants