Typos #25288
Merged
Typos #25288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
reviewed
Feb 21, 2024
| @@ -27,7 +27,7 @@ exports[`generator - Knative Using Helm generator type MySQL and PostgreSQL micr | |||
|
|
|||
| ## Preparation | |||
|
|
|||
| - Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and kntaive installed | |||
| - Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and knative installed | |||
There was a problem hiding this comment.
It seems like Istio and Knative should both be capitalized because they're nouns, not commands.
mraible
previously approved these changes
Feb 21, 2024
mraible
reviewed
Feb 21, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Preparation | |||
|
|
|||
| * Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and kntaive installed | |||
| * Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and Knative installed | |||
There was a problem hiding this comment.
Suggested change
| * Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and Knative installed | |
| * Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have Istio and Knative installed |
|
@qmonmert Looks good! I think you need to update the snapshot for tests to pass. |
mraible
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.