Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Upgrade keycloak 21.x #22429

Merged
merged 21 commits into from
Jun 8, 2023

Conversation

BrayanMnz
Copy link
Contributor

@BrayanMnz BrayanMnz commented Jun 5, 2023

Close #21819
Related with #21938

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Sorry, something went wrong.

BrayanMnz added 4 commits June 5, 2023 16:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
updating keycloak healthcheck since new images doesn't bring with curl.
using netcat utility instead.

Fix jhipster#21819
running npm run update-snapshots.

Fix jhipster#21819
upgrade to Keycloak 21.1.1

Fix jhipster#21819
upgrade to Keycloak 21.1.1

Fix jhipster#21819
@BrayanMnz
Copy link
Contributor Author

May you trigger the checks? @DanielFran

@BrayanMnz BrayanMnz mentioned this pull request Jun 5, 2023
6 tasks
@BrayanMnz
Copy link
Contributor Author

As I said on the previous PR related to this

The checks are failing due to exceptions like this

Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/openid-configuration": Unexpected end of file from server

I have seen that some people reported this before to JHipster but this is not something that I can say is caused by the Keycloak upgrade.

You can see here #13733 where @mraible dealt with the same issue,
@mraible do you have any input here that you remember was helpful when you faced that issue?

@mraible
Copy link
Contributor

mraible commented Jun 5, 2023

@BrayanMnz It looks like you need to update snapshots with npm run update-snapshots.

@BrayanMnz
Copy link
Contributor Author

done @mraible but, the issue that I've mentioned above still exists.

Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/openid-configuration": Unexpected end of file from server

@mshima
Copy link
Member

mshima commented Jun 6, 2023

Failures looks related to keycloak not been ready.
Keycloak v20 is taking more than 50 to be healthy, v21 is taking little more than 20 including download and build.

@BrayanMnz
Copy link
Contributor Author

Hi @mshima can you enable the checks to run for the PR?

@BrayanMnz
Copy link
Contributor Author

Failures looks related to keycloak not been ready. Keycloak v20 is taking more than 50 to be healthy, v21 is taking little more than 20 including download and build.

you mean this failure?
Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/openid-configuration": Unexpected end of file from server

@mshima
Copy link
Member

mshima commented Jun 6, 2023

Failures looks related to keycloak not been ready. Keycloak v20 is taking more than 50 to be healthy, v21 is taking little more than 20 including download and build.

you mean this failure? Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/openid-configuration": Unexpected end of file from server

I think so.

@mraible
Copy link
Contributor

mraible commented Jun 6, 2023

@BrayanMnz It seems the health check you've switched to isn't working. I found a couple of resources that might help:

I also asked ChatGPT. It suggested wget or nc: https://chat.openai.com/share/a41f5514-8ca7-48cf-b348-b0a995498971

@BrayanMnz
Copy link
Contributor Author

It is again failing with Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/ope

Do you suggest increasing the timeout for keycloak? @mshima

@mshima
Copy link
Member

mshima commented Jun 6, 2023

Still need to adjust the healthy check, it's not working yet.

@BrayanMnz
Copy link
Contributor Author

BrayanMnz commented Jun 6, 2023 via email

@mshima
Copy link
Member

mshima commented Jun 6, 2023

It’s not working:
v20 log:
IMG_0029

v21 log ends without start the service:
IMG_0028

Co-authored-by: Matt Raible <matt@raibledesigns.com>
@mraible
Copy link
Contributor

mraible commented Jun 8, 2023

The health check still seems to be failing. If I try to run it locally, it complains the file is not executable. After I chmod +x, it complains that the timeout command is not found. I'm not sure if this provides any insight.

@mshima
Copy link
Member

mshima commented Jun 8, 2023

@mraible great, it’s working.
Just need to replicate healthcheck to the compose file:
https://github.com/BrayanMnz/generator-jhipster/blob/b6fba84e80ae2bdfc8e5b89863e1ad55518e8415/generators/docker-compose/templates/docker-compose.yml.ejs#L127

@mraible mraible enabled auto-merge (squash) June 8, 2023 21:26
@mraible mraible merged commit bdb0ac9 into jhipster:main Jun 8, 2023
@mraible
Copy link
Contributor

mraible commented Jun 8, 2023

Thanks for your contribution, @BrayanMnz!

@BrayanMnz
Copy link
Contributor Author

Thank you to the whole team! @mraible
Looking forward for the next one, let me know if you have something special that need an extra hand.

(It's a holiday in my country today, sorry for being inactive)

@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
@BrayanMnz
Copy link
Contributor Author

@DanielFran
Copy link
Member

@BrayanMnz approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Keycloak dependency and realm configurations to v21.x
4 participants