-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Upgrade keycloak 21.x #22429
feat : Upgrade keycloak 21.x #22429
Conversation
updating keycloak healthcheck since new images doesn't bring with curl. using netcat utility instead. Fix jhipster#21819
running npm run update-snapshots. Fix jhipster#21819
upgrade to Keycloak 21.1.1 Fix jhipster#21819
upgrade to Keycloak 21.1.1 Fix jhipster#21819
May you trigger the checks? @DanielFran |
As I said on the previous PR related to this The checks are failing due to exceptions like this Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "http://localhost:9080/realms/jhipster/.well-known/openid-configuration": Unexpected end of file from server I have seen that some people reported this before to JHipster but this is not something that I can say is caused by the Keycloak upgrade. You can see here #13733 where @mraible dealt with the same issue, |
@BrayanMnz It looks like you need to update snapshots with |
done @mraible but, the issue that I've mentioned above still exists.
|
Failures looks related to keycloak not been ready. |
Hi @mshima can you enable the checks to run for the PR? |
you mean this failure? |
I think so. |
@BrayanMnz It seems the health check you've switched to isn't working. I found a couple of resources that might help: I also asked ChatGPT. It suggested |
It is again failing with Do you suggest increasing the timeout for keycloak? @mshima |
Still need to adjust the healthy check, it's not working yet. |
I can see that it is working
…________________________________
De: Marcelo Shima ***@***.***>
Enviado: Monday, June 5, 2023 9:48:45 PM
Para: jhipster/generator-jhipster ***@***.***>
Cc: Brayan Munoz Vargas ***@***.***>; Mention ***@***.***>
Asunto: Re: [jhipster/generator-jhipster] feat : Upgrade keycloak 21.x (PR #22429)
Still need to adjust the healthy check, it's not working yet.
—
Reply to this email directly, view it on GitHub<#22429 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOXS4H6VAZZVCDLREJFZB43XJ2D73ANCNFSM6AAAAAAY3PTSXI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
generators/docker-compose/templates/realm-config/jhipster-realm.json.ejs
Outdated
Show resolved
Hide resolved
generators/docker-compose/templates/realm-config/jhipster-realm.json.ejs
Show resolved
Hide resolved
generators/docker-compose/templates/realm-config/jhipster-realm.json.ejs
Outdated
Show resolved
Hide resolved
generators/docker/templates/src/main/docker/config/realm-config/jhipster-realm.json.ejs
Show resolved
Hide resolved
generators/docker/templates/src/main/docker/config/realm-config/jhipster-realm.json.ejs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Raible <matt@raibledesigns.com>
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
The health check still seems to be failing. If I try to run it locally, it complains the file is not executable. After I |
@mraible great, it’s working. |
Thanks for your contribution, @BrayanMnz! |
Thank you to the whole team! @mraible (It's a holiday in my country today, sorry for being inactive) |
bounty claimed https://opencollective.com/generator-jhipster/expenses/143406. |
@BrayanMnz approved |
Close #21819
Related with #21938
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.