Modularize more pom dependencies #21712
Merged
+182
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFran
requested changes
Apr 5, 2023
| { groupId: 'org.testcontainers', artifactId: 'mongodb', scope: 'test' }, | ||
| ], | ||
| dependencyManagement: [ | ||
| // Fix Mongock dependencies: https://github.com/mongock/mongock-jdk17/issues/6 |
There was a problem hiding this comment.
Not sure we need that since we removed the reflections 0.10.2 in the bom project in jhipster/jhipster-bom#1246
There was a problem hiding this comment.
I think it won't break too.
But since the latest version (0.10.2) is known to be broken, IMO the safest bet is to force the version to make sure others dependencies won't bring an updated version.
There was a problem hiding this comment.
We can remove if you feel confident.
DanielFran
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.