Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up multipart #9076

Closed
lachlan-roberts opened this issue Dec 21, 2022 · 3 comments
Closed

Clean up multipart #9076

lachlan-roberts opened this issue Dec 21, 2022 · 3 comments
Assignees

Comments

@lachlan-roberts
Copy link
Contributor

lachlan-roberts commented Dec 21, 2022

Enhancement Description

A number of improvements have been discovered while working on #9066 and should be addressed (but are not related to #9066)

@gregw
Copy link
Contributor

gregw commented Dec 22, 2022

As part of the cleanup, we need to address the Part.write() API. This is currently always copying the part into a new file. However the API allows for this to be a move operation.
Potentially the parts should be stored in the non-context temp directory and only moved the the location directory when given a filename here . This will allows the DelayedHandler to avoid being context specific with its temp file usage.

@sbordet
Copy link
Contributor

sbordet commented Dec 22, 2022

@gregw specific implementations of Part such as PathPart do use Files.move() already.

@lachlan-roberts
Copy link
Contributor Author

Merged #9287 #9344 #9345 and #9357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants