Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedirectRegexRule and RewritePatternRule should consider relativeRedirectAllowed #11014

Closed
dsmiley opened this issue Dec 3, 2023 · 1 comment · Fixed by #11019
Closed

RedirectRegexRule and RewritePatternRule should consider relativeRedirectAllowed #11014

dsmiley opened this issue Dec 3, 2023 · 1 comment · Fixed by #11019
Labels
Enhancement

Comments

@dsmiley
Copy link

dsmiley commented Dec 3, 2023

There is an HttpConfiguration option "relativeRedirectAllowed" that is taken into consideration by sendRedirect(). But RedirectRegexRule and RewritePatternRule don't use that sendRedirect. Perhaps they should?
@gregw
Copy link
Contributor

gregw commented Dec 4, 2023

This already appears fixed in Jetty-12 as we do this check in Request.toRedirectURI which is used by the rewrite rules.. although there is a TODO there.
Thus this is mostly a 10/11 issue.

gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
087191d 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Improve relative redirect handling #11014
8764231 
Common relative redirect method.
Use the relative redirect method from redirection rules.

Signed-off-by: gregw <gregw@webtide.com>
This was referenced Dec 4, 2023
Merged
Merged
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
9dea2e0 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
6dbc7b4 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
dc312da 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
@joakime joakime linked a pull request Dec 4, 2023 that will close this issue
Issue #11014 - Cleanup of relative redirect handling Jetty-12 #11019
Merged
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
cd195ff 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
8a5ca86 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 4, 2023
@gregw
Cleanup of relative redirect handling #11014
14bede5 
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
gregw added a commit that referenced this issue Dec 6, 2023
@gregw
Issue #11014 - Improve Relative Redirect Handling in Jetty 10/11 (#11018
7f2859a 
)

* Improve relative redirect handling #11014
* Common relative redirect method.
* Use the relative redirect method from redirection rules.

Signed-off-by: gregw <gregw@webtide.com>
gregw added a commit that referenced this issue Dec 6, 2023
@gregw
Issue #11014 - Cleanup of relative redirect handling Jetty-12 (#11019)
7135433 
* Cleanup of relative redirect handling #11014
+ Handle request relative redirects
+ Moved to Response
+ Changed default to allow relative
* Updates to javadoc
@gregw gregw closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
No open projects
Jetty 10.0.19 / 11.0.19 - FROZEN
Status: ✅ Done
Jetty 12.0.5 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #11014 - Cleanup of relative redirect handling Jetty-12 jetty/jetty.project
2 participants
@gregw @dsmiley