fix restoring incorrect cache #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the broad restore cache keys, the action would restore incorrect cache keys. This is a problem when more than one project is analyzed in the same repo, or if there are multiple qodana configs being analyzed.
tiulpin
added a commit
that referenced
this pull request
Apr 20, 2023
tiulpin
added a commit
that referenced
this pull request
Apr 20, 2023
tiulpin
added a commit
that referenced
this pull request
Apr 20, 2023
tiulpin
added a commit
that referenced
this pull request
Apr 24, 2023
|
Implemented recently, thanks for the suggestion, see https://github.com/JetBrains/qodana-action#configuration The related issue on our tracker: https://youtrack.jetbrains.com/issue/QD-5707/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
This PR fixes an issue where Qodana would restore incorrect cache keys.
Description
Removed keys that do not contain
additional-cache-hash.An alternative chance would be to make the
additional-cache-hashas the key prefix, instead of suffix.Related Issue
Unable to open issues in this repo.
Motivation and Context
With the broad restore cache keys, the action would restore incorrect cache keys. This is a problem when more than one project is analyzed in the same repo, or if there are multiple qodana configs being analyzed.
How Has This Been Tested
Not tested, but change is simple and obvious.
Types of changes
Checklist