From fcfeac47ae7b55ff0396d786fd992c8030b8d899 Mon Sep 17 00:00:00 2001 From: Julian Dax Date: Thu, 23 Feb 2023 10:11:17 +0100 Subject: [PATCH 1/2] refactor(jest-message-util): delete needless 'if' in AggregateError test --- .../__snapshots__/messages.test.ts.snap | 6 ++-- .../src/__tests__/messages.test.ts | 32 +++++++++---------- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.ts.snap b/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.ts.snap index 57c2a440f981..2fcb42f8fee4 100644 --- a/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.ts.snap +++ b/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.ts.snap @@ -76,16 +76,16 @@ exports[`on node >=15.0.0 should return the inner errors of an AggregateError 1` AggregateError: - at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:441:24) + at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:440:22) Errors contained in AggregateError: Err 1 - at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:442:9) + at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:441:7) Err 2 - at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:443:9) + at Object. (packages/jest-message-util/src/__tests__/messages.test.ts:442:7) " `; diff --git a/packages/jest-message-util/src/__tests__/messages.test.ts b/packages/jest-message-util/src/__tests__/messages.test.ts index e9bebb3f6e3a..f76f6f7d7e34 100644 --- a/packages/jest-message-util/src/__tests__/messages.test.ts +++ b/packages/jest-message-util/src/__tests__/messages.test.ts @@ -437,22 +437,20 @@ it('should return the error cause if there is one', () => { onNodeVersions('>=15.0.0', () => { it('should return the inner errors of an AggregateError', () => { // See https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V15.md#v8-86---35415 - if (AggregateError) { - const aggError = new AggregateError([ - new Error('Err 1'), - new Error('Err 2'), - ]); - const message = formatExecError( - aggError, - { - rootDir: '', - testMatch: [], - }, - { - noStackTrace: false, - }, - ); - expect(message).toMatchSnapshot(); - } + const aggError = new AggregateError([ + new Error('Err 1'), + new Error('Err 2'), + ]); + const message = formatExecError( + aggError, + { + rootDir: '', + testMatch: [], + }, + { + noStackTrace: false, + }, + ); + expect(message).toMatchSnapshot(); }); }); From c505f1e0ef80fd4bfdf91768c24536bd429e2ccb Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Thu, 23 Feb 2023 13:20:33 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cde23dbe2ce7..7fc21dbe518a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ - `[jest-changed-files]` Support Sapling ([#13941](https://github.com/facebook/jest/pull/13941)) - `[jest-cli, jest-config, @jest/core, jest-haste-map, @jest/reporters, jest-runner, jest-runtime, @jest/types]` Add `workerThreads` configuration option to allow using [worker threads](https://nodejs.org/dist/latest/docs/api/worker_threads.html) for parallelization ([#13939](https://github.com/facebook/jest/pull/13939)) - `[@jest/create-cache-key-function]` Allow passing `length` argument to `createCacheKey()` function and set its default value to `16` on Windows ([#13827](https://github.com/facebook/jest/pull/13827)) -- `[jest-message-util]` Add support for [AggregateError](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) ([#13946](https://github.com/facebook/jest/pull/13946)) +- `[jest-message-util]` Add support for [AggregateError](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) ([#13946](https://github.com/facebook/jest/pull/13946) & [#13947](https://github.com/facebook/jest/pull/13947)) - `[jest-worker]` Add `start` method to worker farms ([#13937](https://github.com/facebook/jest/pull/13937)) ### Fixes