Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow ESLint 9 as peer dependency #1547

Merged
merged 1 commit into from Apr 6, 2024
Merged

fix: allow ESLint 9 as peer dependency #1547

merged 1 commit into from Apr 6, 2024
+67 −101

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 6, 2024

No description provided.

@SimenB SimenB linked an issue Apr 6, 2024 that may be closed by this pull request
eslint v9 has just been released and support for v9 would be greatly appreciated #1546
Closed
@github-actions github-actions bot added the bug label Apr 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

Fails
🚫 Please include a body for your PR

Generated by 🚫 dangerJS against a44d276

@SimenB SimenB merged commit 3c5e167 into next Apr 6, 2024
34 of 35 checks passed
@SimenB SimenB deleted the 9-is-out branch April 6, 2024 08:00
@G-Rath
Copy link
Collaborator

G-Rath commented Apr 6, 2024

Beat me to it 😁

github-actions bot pushed a commit that referenced this pull request Apr 6, 2024
@semantic-release-bot
chore(release): 28.0.0-next.7 [skip ci]
37f1d69 
# [28.0.0-next.7](v28.0.0-next.6...v28.0.0-next.7) (2024-04-06)

### Bug Fixes

* allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167))
* drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388))

### BREAKING CHANGES

* Node v19 is no longer supported
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

🎉 This PR is included in version 28.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 6, 2024
@semantic-release-bot
chore(release): 28.0.0 [skip ci]
5bc0b88 
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06)

### Bug Fixes

* allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167))
* drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388))
* **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))

### Features

* drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355))
* drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580))
* remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8))
* remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9))
* upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd))

### BREAKING CHANGES

* Node v19 is no longer supported
* removed unneeded `snapshot` processor and `flat/snapshot` config
* dropped support for `@typescript-eslint/eslint-plugin` v5
* dropped support for Node v14
* removed `no-if` in favor of `no-conditional-in-test`
@G-Rath G-Rath mentioned this pull request Apr 6, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

G-Rath
G-Rath reviewed Apr 6, 2024
View reviewed changes
package.json
@@ -86,7 +86,7 @@
"babel-jest": "^29.0.0",
"babel-plugin-replace-ts-export-assignment": "^0.0.2",
"dedent": "^1.5.0",
"eslint": "^7.0.0 || ^8.0.0",
"eslint": "^7.0.0 || ^8.0.0 || ^9.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB is there some Yarn trick I don't know about to actually select the version to use locally without a git change?

I'm finding that v9 is being installed, which completely breaks my IDE and tests - alternatively, could we remove v9 from this list? CI was running fine with installing next without this so I don't know quite why we need it 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we don't really need it here (which causes renovate to install v9)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have opened #1569

@anthony0030
Copy link

I am getting this warning:

warning "eslint-plugin-jest > @typescript-eslint/utils@6.21.0" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0".

Is it related?

@SimenB
Copy link
Member Author

SimenB commented Apr 22, 2024

@anthony0030 typescript-eslint/typescript-eslint#8211

(we will probably need to update to v7 whenever that is actually fixed)

Things should work fine even with the warning, tho.

@anthony0030
Copy link

@SimenB thankyou for the info 😃

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 24, 2024
Open
7 tasks
@G-Rath G-Rath mentioned this pull request Apr 26, 2024
Merged
@pplancq pplancq mentioned this pull request May 6, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath left review comments

Assignees
No one assigned
Labels
bug released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint v9 has just been released and support for v9 would be greatly appreciated
3 participants
@SimenB @G-Rath @anthony0030