Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major #1531

Merged
merged 24 commits into from Apr 6, 2024
Merged

Next major #1531

merged 24 commits into from Apr 6, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 23, 2024

The only major changes left I can think of are changes to config and rule defaults (of which I can't think of any we actually wanted to do?) and maybe changing our snapshot processor which I'm not actually sure we need anymore? (Will discuss on #292)

Resolves #292

G-Rath and others added 10 commits March 22, 2024 08:28
BREAKING CHANGE: removed `no-if` in favor of `no-conditional-in-test`
# [28.0.0-next.1](v27.9.0...v28.0.0-next.1) (2024-03-21)

### Features

* remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8))

### BREAKING CHANGES

* removed `no-if` in favor of `no-conditional-in-test`
BREAKING CHANGE: dropped support for Node v14
# [28.0.0-next.2](v28.0.0-next.1...v28.0.0-next.2) (2024-03-21)

### Features

* drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580))

### BREAKING CHANGES

* dropped support for Node v14
* feat: upgrade to `@typescript-eslint/utils` v6

* chore: remove invalid module declarations

* fix: update `docs` meta property on rules

* chore: cast `context.settings` for now

* refactor: update deprecated method calls

* fix: update types for `JSONSchema4`

* test(unbound-method): update cases and structure

* test(unbound-method): use `TSESLint.RuleTester`

* test(unbound-method): include filename for invalid cases

* test(unbound-method): don't run broken test when using `@typescript-eslint` v5

* fix: address deprecation warning
# [28.0.0-next.3](v28.0.0-next.2...v28.0.0-next.3) (2024-03-22)

### Features

* upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd))
BREAKING CHANGE: dropped support for `@typescript-eslint/eslint-plugin` v5
# [28.0.0-next.4](v28.0.0-next.3...v28.0.0-next.4) (2024-03-23)

### Features

* drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355))

### BREAKING CHANGES

* dropped support for `@typescript-eslint/eslint-plugin` v5
G-Rath and others added 9 commits March 24, 2024 14:28
BREAKING CHANGE: removed unneeded `snapshot` processor and `flat/snapshot` config
# [28.0.0-next.5](v28.0.0-next.4...v28.0.0-next.5) (2024-03-27)

### Features

* remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9))

### BREAKING CHANGES

* removed unneeded `snapshot` processor and `flat/snapshot` config
…1540)

* test(prefer-comparison-matcher): update test names

* test(prefer-comparison-matcher): deduplicate examples
# [28.0.0-next.6](v28.0.0-next.5...v28.0.0-next.6) (2024-03-29)

### Bug Fixes

* **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))
@G-Rath G-Rath marked this pull request as ready for review March 29, 2024 23:35
@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 29, 2024

I think this is good to go - there's a few fixes that don't require a new major but I didn't land them in main to avoid a rebase, but given we have to do that now anyway we could cherry-pick? I'm not fussed 🤷

@G-Rath G-Rath requested a review from SimenB March 29, 2024 23:37
G-Rath and others added 2 commits April 1, 2024 07:32
* ci: run against next ESLint

* test: make util

* test: use a class

* test: use a class (2)

* test: improve compat class

* refactor: make `flatCompat` util private

* test: get `linter#verify` cases passing

* ci: skip lint project on eslint v9

* test: ignore coverage in util class

* chore: move Jest config into dedicated file

* ci: handle skipping linting in Jest config

* test: skip `unbound-method` when using `@typescript-eslint` v6

* ci: skip ESLint v9 on Node v16

* refactor: import `Config` from `jest` directly

* refactor: address `@ts-expect-error`s

* refactor: use a constant instead of a function
@github-actions github-actions bot added the bug label Apr 6, 2024
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

# [28.0.0-next.7](v28.0.0-next.6...v28.0.0-next.7) (2024-04-06)

### Bug Fixes

* allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167))
* drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388))

### BREAKING CHANGES

* Node v19 is no longer supported
@SimenB SimenB merged commit 7ecbae2 into main Apr 6, 2024
@SimenB SimenB deleted the next branch April 6, 2024 08:09
Copy link

github-actions bot commented Apr 6, 2024

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB
Copy link
Member

SimenB commented Apr 6, 2024

Incredible work on this release @G-Rath, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap processor makes enforcing other rules on .snap files impossible
3 participants