feat: upgrade @typescript-eslint/utils to v6
#1508
Conversation
github-actions
bot
added
rule: max-nested-describe
rule: no-deprecated-functions
rule: no-confusing-set-timeout
rule: no-disabled-tests
rule: consistent-test-it
rule: max-expects
rule: no-conditional-in-test
rule: expect-expect
rule: no-done-callback
rule: no-conditional-expect
rule: no-untyped-mock-factory
rule: no-restricted-jest-methods
rule: no-identical-title
rule: no-test-return-statement
rule: no-focused-tests
rule: no-mocks-import
rule: no-commented-out-tests
rule: no-duplicate-hooks
rule: no-restricted-matchers
rule: prefer-to-contain
rule: prefer-called-with
rule: prefer-expect-assertions
rule: prefer-each
rule: no-if
rule: valid-describe-callback
rule: no-large-snapshots
rule: valid-title
rule: no-hooks
rule: prefer-to-have-length
labels
|
rebase and it should be good? |
|
Yup, I'm just doing a couple of things at once while I wait for CIs in different projects to finish 😛 |
G-Rath
force-pushed
the
update-typescript-eslint
branch
from
3dca273
to
b8d120d
Compare
| @@ -95,7 +95,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@typescript-eslint/utils": "^5.10.0" | |||
| "@typescript-eslint/utils": "^6.0.0" | |||
There was a problem hiding this comment.
we're still supporting @typescript-eslint/eslint-plugin v5 and don't use a lot of the actual rules so I don't think there's a strong advantage - I'll double check that but I don't think it should block landing this right now
There was a problem hiding this comment.
I think we can drop it - no reason too keep support when bumping version (when we're landing as major regardless)
There was a problem hiding this comment.
ok but can we do that in a PR after this so it gets a dedicated changelog entry?
There was a problem hiding this comment.
i.e. I think it makes sense to add support for further majors as a minor, but if we're doing a major release regardless, I don't think it's super valuable (beyond this special case when we're 2 majors behind 😅 )
There was a problem hiding this comment.
(sorry, I had the tab open and GH isn't super good with live updates 😅 let's blame rails!)
There was a problem hiding this comment.
Suggestion: update this to the last v6 version.
That way you're enforcing that package managers always give you the latest version, rather than trying to resolve to some random one with fewer bug fixes.
There was a problem hiding this comment.
I tend to favor not doing that to enable better deduplication downstream, given we consider this a very stable dependency
| 'Promise.resolve().then(console.log);', | ||
| "['1', '2', '3'].map(Number.parseInt);", | ||
| '[5.2, 7.1, 3.6].map(Math.floor);', | ||
| 'const x = console.log;', | ||
| ...(parseInt(rawTypeScriptESLintPluginVersion.split('.')[0], 10) >= 6 |
There was a problem hiding this comment.
(also, we should use semver module for this)
There was a problem hiding this comment.
No because we still support and test against @typescript-eslint/eslint-plugin v5
There was a problem hiding this comment.
I'll not replace this with semver since it'll just go away right after this PR when we drop support for v5
| @@ -70,11 +68,14 @@ export default createRule< | |||
| ignore: { | |||
| type: 'array', | |||
| items: { | |||
| type: 'string', | |||
| // for some reason TypeScript thinks this _must_ be a read-only | |||
There was a problem hiding this comment.
We probably need to update our parameter types to be const parameters to avoid weirdness like this.
G-Rath
force-pushed
the
update-typescript-eslint
branch
from
bf802b2
to
e1024e7
Compare
# [28.0.0-next.3](v28.0.0-next.2...v28.0.0-next.3) (2024-03-22) ### Features * upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd))
|
🎉 This PR is included in version 28.0.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06) ### Bug Fixes * allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167)) * drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388)) * **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9)) ### Features * drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355)) * drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580)) * remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8)) * remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9)) * upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd)) ### BREAKING CHANGES * Node v19 is no longer supported * removed unneeded `snapshot` processor and `flat/snapshot` config * dropped support for `@typescript-eslint/eslint-plugin` v5 * dropped support for Node v14 * removed `no-if` in favor of `no-conditional-in-test`
|
🎉 This PR is included in version 28.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Really the changes needed were just type and testing based, though I'm not sure if we can support v5 without a breaking change anyway because we'd have to switch to requiring it as a peer dependency which is arguably still breaking?
v6 dropped support for Node v14 which we still support.
Closes #1401
(this is meant to be the min. required for the upgrade - I'll do other stuff like updating the linting plugins in another PR)