Skip to content

Commit ee2647e

Browse files
garykingSimenB
authored andcommittedSep 30, 2018
fix(prefer-strict-equal): only run if expect is used (#163)
1 parent 2894eaa commit ee2647e

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed
 

‎rules/__tests__/prefer-strict-equal.test.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ const rule = require('../prefer-strict-equal');
66
const ruleTester = new RuleTester();
77

88
ruleTester.run('prefer-strict-equal', rule, {
9-
valid: ['expect(something).toStrictEqual(somethingElse);'],
9+
valid: [
10+
'expect(something).toStrictEqual(somethingElse);',
11+
"a().toEqual('b')",
12+
],
1013
invalid: [
1114
{
1215
code: 'expect(something).toEqual(somethingElse);',

‎rules/prefer-strict-equal.js

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
'use strict';
22

3+
const expectCase = require('./util').expectCase;
34
const getDocsUrl = require('./util').getDocsUrl;
5+
const method = require('./util').method;
46

57
module.exports = {
68
meta: {
@@ -12,14 +14,19 @@ module.exports = {
1214
create(context) {
1315
return {
1416
CallExpression(node) {
15-
const propertyName = node.callee.property && node.callee.property.name;
17+
if (!expectCase(node)) {
18+
return;
19+
}
20+
21+
const propertyName = method(node) && method(node).name;
22+
1623
if (propertyName === 'toEqual') {
1724
context.report({
1825
fix(fixer) {
19-
return [fixer.replaceText(node.callee.property, 'toStrictEqual')];
26+
return [fixer.replaceText(method(node), 'toStrictEqual')];
2027
},
2128
message: 'Use toStrictEqual() instead',
22-
node: node.callee.property,
29+
node: method(node),
2330
});
2431
}
2532
},

0 commit comments

Comments
 (0)
Please sign in to comment.