Skip to content

Commit 9a6ce6c

Browse files
jackfranklinSimenB
authored andcommittedOct 16, 2018
fix(prefer-expect-assertions): fix greedy regex
1 parent 9b5939e commit 9a6ce6c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed
 

Diff for: ‎rules/__tests__/prefer-expect-assertions.test.js

+2
Original file line numberDiff line numberDiff line change
@@ -87,5 +87,7 @@ ruleTester.run('prefer-expect-assertions', rule, {
8787
'\n\t\t\texpect(someValue).toBe(true)\n' +
8888
'\t\t\t})',
8989
'test("it1")',
90+
'itHappensToStartWithIt("foo", function() {})',
91+
'testSomething("bar", function() {})',
9092
],
9193
});

Diff for: ‎rules/prefer-expect-assertions.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module.exports = {
5454
},
5555
create(context) {
5656
return {
57-
'CallExpression[callee.name=/^it|test$/][arguments.1.body.body]'(node) {
57+
'CallExpression[callee.name=/^(it|test)$/][arguments.1.body.body]'(node) {
5858
const testFuncBody = node.arguments[1].body.body;
5959

6060
if (!isFirstLineExprStmt(testFuncBody)) {

0 commit comments

Comments
 (0)
Please sign in to comment.