fix(unbound-method): don't suppress errors from base rule (#1219)

BREAKING CHANGE: errors thrown by the `unbound-method` base rule are no longer suppressed - really this means that if you don't specify `project` when this rule is enabled and `@typescript-eslint/eslint-plugin` is present, that error will no longer be suppressed instead of silently doing nothing; it will still not throw if this rule is enabled without the base rule being present

Author: G-Rath

src/rules/__tests__/unbound-method.test.ts

@@ -182,25 +182,6 @@ describe('error handling', () => {
       },
     );
   });
-
-  describe('when "project" is not set', () => {
-    const ruleTester = new ESLintUtils.RuleTester({
-      parser: '@typescript-eslint/parser',
-      parserOptions: {
-        sourceType: 'module',
-        tsconfigRootDir: rootPath,
-      },
-    });
-
-    ruleTester.run(
-      'unbound-method jest edition without "project" property',
-      requireRule(false),
-      {
-        valid: validTestCases.concat(invalidTestCases.map(({ code }) => code)),
-        invalid: [],
-      },
-    );
-  });
 });
 
 ruleTester.run('unbound-method jest edition', requireRule(false), {

src/rules/unbound-method.ts

@@ -33,16 +33,6 @@ const baseRule = (() => {
   }
 })();
 
-const tryCreateBaseRule = (
-  context: Readonly<TSESLint.RuleContext<MessageIds, Options>>,
-) => {
-  try {
-    return baseRule?.create(context);
-  } catch {
-    return null;
-  }
-};
-
 interface Config {
   ignoreStatic: boolean;
 }
@@ -75,7 +65,7 @@ export default createRule<Options, MessageIds>({
     },
   },
   create(context) {
-    const baseSelectors = tryCreateBaseRule(context);
+    const baseSelectors = baseRule?.create(context);
 
     if (!baseSelectors) {
       return {};