Skip to content

Commit 4e4313e

Browse files
msvabSimenB
authored andcommittedOct 2, 2018
fix(no-focused-tests): detect usage like 'test.only.each()'
1 parent 9ea1f78 commit 4e4313e

File tree

2 files changed

+31
-9
lines changed

2 files changed

+31
-9
lines changed
 

Diff for: ‎rules/__tests__/no-focused-tests.test.js

+12
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ ruleTester.run('no-focused-tests', rule, {
2323
code: 'describe.only()',
2424
errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
2525
},
26+
{
27+
code: 'describe.only.each()',
28+
errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
29+
},
2630
{
2731
code: 'describe["only"]()',
2832
errors: [{ message: expectedErrorMessage, column: 10, line: 1 }],
@@ -31,6 +35,10 @@ ruleTester.run('no-focused-tests', rule, {
3135
code: 'it.only()',
3236
errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
3337
},
38+
{
39+
code: 'it.only.each()',
40+
errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
41+
},
3442
{
3543
code: 'it["only"]()',
3644
errors: [{ message: expectedErrorMessage, column: 4, line: 1 }],
@@ -39,6 +47,10 @@ ruleTester.run('no-focused-tests', rule, {
3947
code: 'test.only()',
4048
errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],
4149
},
50+
{
51+
code: 'test.only.each()',
52+
errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],
53+
},
4254
{
4355
code: 'test["only"]()',
4456
errors: [{ message: expectedErrorMessage, column: 6, line: 1 }],

Diff for: ‎rules/no-focused-tests.js

+19-9
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,25 @@ module.exports = {
2929
CallExpression(node) {
3030
const callee = node.callee;
3131

32-
if (
33-
callee.type === 'MemberExpression' &&
34-
isCallToTestOnlyFunction(callee)
35-
) {
36-
context.report({
37-
message: 'Unexpected focused test.',
38-
node: callee.property,
39-
});
40-
return;
32+
if (callee.type === 'MemberExpression') {
33+
if (
34+
callee.object.type === 'MemberExpression' &&
35+
isCallToTestOnlyFunction(callee.object)
36+
) {
37+
context.report({
38+
message: 'Unexpected focused test.',
39+
node: callee.object.property,
40+
});
41+
return;
42+
}
43+
44+
if (isCallToTestOnlyFunction(callee)) {
45+
context.report({
46+
message: 'Unexpected focused test.',
47+
node: callee.property,
48+
});
49+
return;
50+
}
4151
}
4252

4353
if (callee.type === 'Identifier' && isCallToFocusedTestFunction(callee)) {

0 commit comments

Comments
 (0)
Please sign in to comment.