fix: set correct property for nonProxyHosts #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there are different system properties for http and https proxies, there is only one shared property for proxy exclusions: http.nonProxyHosts Setting https.nonProxyHosts has no effect on any recent JDK Fixes jeremylong#6283
jeremylong
approved these changes
Dec 12, 2023
|
Thank you for catching my copy/paste mistake. I knew the non-proxy host property is shared... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6283
Description of Change
While there are different system properties for http and https proxies, there is only one shared property for proxy exclusions:
http.nonProxyHostsSetting
https.nonProxyHostshas no effect on any recent JDKHave test cases been added to cover the new functionality?
no