Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support msbuild Directory.build.props #5475

Merged
merged 16 commits into from
Mar 10, 2023

Conversation

jeremylong
Copy link
Owner

@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Feb 19, 2023
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding of interpolation is not in line with its documented behaviour (was previously already an error in interpolation method in the Model class).

@jeremylong jeremylong force-pushed the feat/msbuild/Directory.build.Props branch from da744ad to b9b0309 Compare February 20, 2023 15:15
@jeremylong
Copy link
Owner Author

@aikebah thank you for the review and comments. Everything should be good to go now - with the exception of the error handling. I will update that in a day or two before finalizing and merging this PR.

@aikebah
Copy link
Collaborator

aikebah commented Feb 21, 2023

@aikebah thank you for the review and comments. Everything should be good to go now - with the exception of the error handling. I will update that in a day or two before finalizing and merging this PR.

YW, always keen to try and find potential issues before features are introduced. Have made a habit of reading specs and checking whether code is matching specs (though reading the specs of the MSBuild documentation leaves and itchy feeling due to their free format open-endedness so that you can only 'try your best to conform to whatever Visual Studio happens to do').

I prefer the formal specs where you can really determine what is conformant and what not. I think your updated naive implementation is the best we can do (which covers the only usages that I would trust to reliably work now and in the future in my projects were I to be a dotnet developer with Visual Studio solutions projects given the documentation that Microsoft has put up for it)

@jeremylong jeremylong force-pushed the feat/msbuild/Directory.build.Props branch from 9fcc995 to 1067d7a Compare February 27, 2023 13:03
@jeremylong jeremylong merged commit 2545ac6 into main Mar 10, 2023
@jeremylong jeremylong deleted the feat/msbuild/Directory.build.Props branch March 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSBuild analyzer could (should?) check for props files as well
2 participants