Make it possible to use create_or_replace_view with materialized view. #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to use CREATE OR REPLACE with materialized view in Postgres so we should fallback to `drop_view`/`create_view` calls when we use `create_or_replace_view` method with `:materialized` option.
nashby
commented
Mar 27, 2024
| @@ -252,10 +252,10 @@ def create_table_generator(&block) | |||
| # For databases where replacing a view is not natively supported, support | |||
| # is emulated by dropping a view with the same name before creating the view. | |||
| def create_or_replace_view(name, source, options = OPTS) | |||
| if supports_create_or_replace_view? | |||
| if supports_create_or_replace_view? && !options[:materialized] | |||
There was a problem hiding this comment.
I wasn't sure if it's too specific for postgres and we should have separate create_or_replace_view specifically for postgres. let me know if you want to change that
|
Thanks for the patch! I think your implementation looks fine. If we do eventually have another database that supports replacing materialized views, we can adjust at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to use CREATE OR REPLACE with materialized view in Postgres so we should fallback to
drop_view/create_viewcalls when we usecreate_or_replace_viewmethod with:materializedoption.Currently when
create_or_replace_viewis called you get