Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastLocation testing #332

Merged
merged 1 commit into from
Aug 18, 2023
Merged

lastLocation testing #332

merged 1 commit into from
Aug 18, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 17, 2023

Pairs with jenkinsci/durable-task-plugin#187. I noticed a flake in ExecutorStepTest.contextualizeFreshFilePathAfterAgentReconnection[watching=true]: the test timed out, and the log included

WARNING: org.jenkinsci.plugins.durabletask.FileMonitoringTask$Watcher@… giving up on watching …/dumbo/workspace/demo@tmp/durable-…
java.lang.NumberFormatException: For input string: ""
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Long.parseLong(Long.java:702)
	at java.base/java.lang.Long.parseLong(Long.java:817)
	at org.jenkinsci.plugins.durabletask.FileMonitoringTask$Watcher.run(FileMonitoringTask.java:622)

I do not have a clear hypothesis as to why lastLocation was empty; perhaps a half-written file could be to blame, in which case using AtomicFileWriter could help, but this seems dubious when the same process should have already finished writing the same file.

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
@jglick jglick added the tests label Aug 17, 2023
@jglick jglick requested a review from dwnusbaum August 17, 2023 23:39
@jglick jglick merged commit a96d25d into jenkinsci:master Aug 18, 2023
@jglick jglick deleted the lastLocation branch August 18, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants