Throw an exception when trying to save actions for a FlowNode for a completed execution

[dwnusbaum]

See jenkinsci/pipeline-build-step-plugin#128 (comment) and the next comment.

If FlowExecution.saveActions is called for a Pipeline with a completed execution, in some cases (all cases as of #807), the save will be a no-op and nothing will be written to disk. Notably this method is called implicitly when updating actions on a FlowNode or when explicitly calling FlowNode.save.

We should throw an error in this case instead to make it easier for developers to detect and identify any issues. Generally speaking, to persist metadata for a possibly-completed build, you should use an Action on the Run that stores FlowNode.getId as needed.

TODO:

• Run PCT to check if this affects tests in significant plugins (Run PCT against workflow-cps PR #826 bom#2785)
• Add test (CpsFlowExecutionTest.flowNodesCantBeSavedAfterExecutionCompletes)

Testing done

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist