Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RejectedExecutionException from CpsFlowExecution.getCurrentExecutions #797

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 3, 2023

Caught and logged as a warning from FlowExecutionList.StepExecutionIteratorImpl when trying to call StepExecution.applyAll at a certain point during shutdown, for example from DurableTaskStep$AgentReconnectionListener.check if an agent is disconnected. In fact that listener does check Jenkins.get().isTerminating() to avoid noise, but unfortunately this flag is set by Jenkins.cleanUp after running @Terminators (and before all other cleanup steps).

@jglick jglick requested a review from a team as a code owner October 3, 2023 23:13
@jglick jglick added the bug label Oct 3, 2023
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine - 4 failing tests on windows? timeout after 180s but other PRs seem to be OK.

@jglick
Copy link
Member Author

jglick commented Oct 4, 2023

Windows CI is just super slow and prone to timeouts.

@jglick jglick requested a review from a team October 4, 2023 16:09
@jglick jglick merged commit d42bfcf into jenkinsci:master Oct 4, 2023
13 checks passed
@jglick jglick deleted the iterateAfterSuspend branch October 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants