Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of Prototype from Steps Reference #749

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jul 18, 2023

Forgotten in #702. Attempting to view the Steps Reference in the UI with Prototype disabled results in

Uncaught ReferenceError: $$ is not defined
    parseDom http://127.0.0.1/adjuncts/0ce4ef4c/org/jenkinsci/plugins/workflow/cps/Snippetizer/workflow.js:3
    <anonymous> http://127.0.0.1/adjuncts/0ce4ef4c/org/jenkinsci/plugins/workflow/cps/Snippetizer/workflow.js:26

Fixed by converting this file to native JavaScript. I also verified there were no other usages of Prototype that I missed. To test this, I reproduced the problem in the Steps Reference view and verified that it could no longer be reproduced after this PR by expanding and contracting steps in the UI.

@basil basil added the internal label Jul 18, 2023
@basil basil requested a review from a team as a code owner July 18, 2023 20:06
@jglick jglick added bug and removed internal labels Jul 18, 2023
@jglick jglick merged commit cd2641b into jenkinsci:master Jul 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants