Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh-ed25519 and ecdsa-sha2-nistp256 algorithms to ManuallyProvidedKeyVerificationStrategy SSH key help text #522

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kryachkov
Copy link
Contributor

Currently ManuallyProvidedKeyVerificationStrategy SSH key help text only mentions ssh-rsa and ssh-dss while ssh-ed25519 and ecdsa-sha2-nistp256 are supported too. It made me spend too much time trying to debug why Jenkins could not establish connection using ssh-rsa key, while it was using ssh-ed25519 and I had no idea I can put ssh-ed25519 key there.

Testing done

Don't think there is much to test

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…dKeyVerificationStrategy SSH key help text
@kryachkov kryachkov requested a review from a team as a code owner October 18, 2024 08:59
@kuisathaverat kuisathaverat merged commit b277a12 into jenkinsci:main Oct 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants