Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72975] Permit java.util.regex.MatchResult.group(String) #562

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

ckullabosch
Copy link
Contributor

@ckullabosch ckullabosch commented Apr 5, 2024

See JENKINS-72975.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@ckullabosch ckullabosch requested a review from a team as a code owner April 5, 2024 14:32
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all of the other new name-related methods added to MatchResult in Java 20 at the same time. Also, you'll need to add all of them to this set for the tests to pass, since we still support Java 17 and use it in one branch of the CI builds:

private static final Set<Signature> KNOWN_GOOD_SIGNATURES = new HashSet<>(Arrays.asList(

@dwnusbaum dwnusbaum enabled auto-merge April 8, 2024 14:18
@dwnusbaum dwnusbaum changed the title [JENKINS-72975] Permit java.util.regex.MatchResult.group(String) [JENKINS-72975] Permit java.util.regex.MatchResult.group(String) Apr 8, 2024
@dwnusbaum dwnusbaum merged commit f07d9ce into jenkinsci:master Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants