Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor enhancements #314

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Minor enhancements #314

merged 4 commits into from
Jul 8, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 8, 2023 •
edited

Some minor enhancements

  • fixed a typo
  • table highlighting works on the cell and not the input to avoid flickering when moving around the mouse
  • highlight row when on the delete button on the right

Internal changes

  • use template element instead of a hidden row that gets removed
  • use let instead of varin js files where applicable

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@mawinter69
fix typo
7f2f713
@mawinter69
highlight row when hovering over last delete button
c30d4b0
@mawinter69
reduce variable scope
dc66e8d
@mawinter69
avoid flickering when moving in the table
57e5c3f 
the hover effect was only on the input. That lead to the highlight be
turned leaving the input end turn it on again in the next cell of the
table. The mouseover is now on the td which avoids the flickering.

move the templates to a template element out of the table.
@mawinter69 mawinter69 requested a review from a team as a code owner July 8, 2023 22:38
@mawinter69 mawinter69 merged commit 4d4f871 into jenkinsci:master Jul 8, 2023
17 checks passed
@mawinter69 mawinter69 deleted the minor-enhancements branch July 13, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement internal
Projects
None yet
Milestone
No milestone
1 participant
@mawinter69