Forward proxy support for WebSocket #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
the
enhancement
basil
commented
Oct 23, 2023
|
|
||
| String proxyHost = System.getProperty("http.proxyHost", System.getenv("proxy_host")); | ||
| String proxyPort = System.getProperty("http.proxyPort"); | ||
| if (proxyHost != null && "http".equals(hudsonUrl.getProtocol()) && NoProxyEvaluator.shouldProxy(hudsonUrl.getHost())) { |
There was a problem hiding this comment.
Compare with JnlpAgentEndpointResolver#openURLConnection
timja
approved these changes
Oct 24, 2023
basil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component supports the
http.proxyHostsystem property (orproxy_hostenvironment variable) for configuring a proxy server, but it is not honored in WebSocket mode. By plumbing this through to Tyrus we can get Tyrus to respect the proxy settings the same way non-WebSocket mode does. Similarly we can plumb through the value of-proxyCredentialsto Tyrus if the user needs to pass in aProxy-Authorizationheader (like we do in non-WebSocket mode). We do this only for HTTP to match the non-WebSocket mode.Testing done
Set up a Squid proxy that required authentication and verified that I could connect through it using: