Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten <repositories> part of deployed pom when using JEP-229 #464

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Flatten <repositories> part of deployed pom when using JEP-229 #464

merged 1 commit into from
Jul 12, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jul 12, 2023 •
edited

Counterpart of jenkinsci/plugin-pom#802,
workarounds mojohaus/flatten-maven-plugin#362

Testing done

Updated pom of stapler with SNAPSHOT of this project

Ran

mvn -Pquick-build -Dset.changelist -Dignore.dirt verify

Verified that **/target/stapler-*-<version>.pom no longer has a <repositories> section.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@Vlatombe Vlatombe mentioned this pull request Jul 12, 2023
Merged
@Vlatombe Vlatombe requested a review from basil July 12, 2023 04:56
basil
basil approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit d3a23bb into jenkinsci:master Jul 12, 2023
2 checks passed
@Vlatombe Vlatombe deleted the flatten-repositories branch July 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vlatombe @basil