Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72059] Add new quality gate options to alter the stage only #309

Merged
merged 21 commits into from Feb 23, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Dec 29, 2023

As requested in JENKINS-72059 it makes sense to publish the quality gate results as a status for a step without touching the overall build status.

Downstream PRs:

@uhafner uhafner added the enhancement Enhancement of existing functionality label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: Patch coverage is 51.25000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 40.49%. Comparing base (358ef35) to head (ad0273a).
Report is 17 commits behind head on main.

❗ Current head ad0273a differs from pull request most recent head afb0e59. Consider uploading reports for the commit afb0e59 to get more accurate results

Files Patch % Lines
...main/java/io/jenkins/plugins/util/QualityGate.java 0.00% 18 Missing ⚠️
...ava/io/jenkins/plugins/util/QualityGateResult.java 27.27% 16 Missing ⚠️
...ava/io/jenkins/plugins/util/NullResultHandler.java 0.00% 3 Missing ⚠️
...ava/io/jenkins/plugins/util/AbstractExecution.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #309       +/-   ##
=============================================
+ Coverage     30.00%   40.49%   +10.49%     
- Complexity       64       97       +33     
=============================================
  Files            20       21        +1     
  Lines           460      526       +66     
  Branches         41       44        +3     
=============================================
+ Hits            138      213       +75     
+ Misses          319      309       -10     
- Partials          3        4        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import static org.assertj.core.api.Assertions.*;
import static org.mockito.Mockito.*;

class QualityGateEvaluatorTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note

Unused class: QualityGateEvaluatorTest is not referenced within this codebase. If not used as an external API it should be removed.
@uhafner uhafner marked this pull request as draft February 20, 2024 12:16
@uhafner uhafner marked this pull request as ready for review February 23, 2024 16:19
@uhafner uhafner merged commit 2ad27f7 into main Feb 23, 2024
26 checks passed
@uhafner uhafner deleted the stage-result branch February 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
1 participant