Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java level profiles for java 17 and java 21 #893

Merged
merged 1 commit into from Feb 9, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Feb 7, 2024

This change is meant to work in tandem with jenkinsci/maven-hpi-plugin#578. Without it, it is essentially a no-op (unless a user enables one of the new profiles explicitly e.g. via -Pjava-level-17)

These will get used by IDEs (e.g. IDEA IntelliJ) to set the appropriate java level if it differs from the default java level defined in the pom file.

In practice, maven-hpi-plugin will generate and manage the files used as activation markers for these profiles, depending on the java level required by the jenkins version the plugin required.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

These will get used by IDEs (e.g. IDEA IntelliJ) to set the appropriate java level if it differs from the default java level defined in the pom file.

In practice, maven-hpi-plugin will generate and manage the files used as activation markers for these profiles, depending on the java level required by the jenkins version the plugin required.
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless for non-IDEA users.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit b5d6788 into jenkinsci:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants