Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PowerMock to banned dependencies #847

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Oct 31, 2023

PowerMock tends to wreak havoc when it is on the classpath at the same time as Mockito in newer Java versions, so ban this dependency. I have not banned org.powermock:powermock-reflect since it is actually safe and some plugins (like Blue Ocean) depend on it. But I have banned every other PowerMock artifact.

Testing done

I tested this in context in a plugin that used powermock-reflect. Attempting to add another PowerMock package caused (as expected):

Rule 4: org.apache.maven.enforcer.rules.dependency.BannedDependencies failed with message:
org.jenkins-ci.plugins:build-blocker-plugin:hpi:1.7.10-SNAPSHOT
   org.powermock:powermock-module-junit4:jar:2.0.9 <--- banned via the exclude/include list

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil merged commit 62af0c3 into jenkinsci:master Oct 31, 2023
2 checks passed
@basil basil deleted the powermock branch October 31, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants