Adapt to jenkinsci/maven-hpi-plugin#461 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added a commit
to basil/bom
that referenced
this pull request
Mar 28, 2023
This was referenced Mar 28, 2023
basil
added a commit
to basil/bom
that referenced
this pull request
Mar 28, 2023
basil
changed the title
basil
added
dependencies
basil
added a commit
to basil/bom
that referenced
this pull request
Mar 28, 2023
basil
added a commit
to basil/bom
that referenced
this pull request
Mar 28, 2023
basil
added a commit
to basil/bom
that referenced
this pull request
Mar 30, 2023
MarkEWaite
pushed a commit
to jenkinsci/bom
that referenced
this pull request
Mar 30, 2023
lemeurherve
pushed a commit
to lemeurherve/bom
that referenced
this pull request
Mar 31, 2023
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/maven-hpi-plugin#461 removes the
overrideWarAdditionsoption, replacing it with default behavior that obviates the need for that option. Before we can removeoverrideWarAdditionsfromjenkinsci/bom, we need to ensure that we are consistently getting that default behavior. This PR achieves that objective. I tested this PR in context injenkinsci/bom.