[JENKINS-47703] - allow building dockerfile on Windows #354

jetersen · 2019-10-10T07:24:29Z

JENKINS issue(s):
- JENKINS-47703
Description:
- Support docker image build on Windows, related to Features/windows agents with pathing issues fixed docker-workflow-plugin#184
Documentation changes:
- N/A
Users/aliases to notify:
- @bitwiseman

jetersen · 2019-10-10T11:29:16Z

Would be great to include in current release and the beta

oleg-nenashev

Looks right

jetersen · 2019-10-11T20:38:29Z

🙏

jetersen · 2019-10-16T21:33:39Z

Poking @dwnusbaum and @bitwiseman 😓

henryborchers · 2019-10-17T14:44:38Z

I'm hoping this can go through soon. Access to building Dockerfiles on Windows will allow me to actually use the Windows Docker containers in Jenkins. It'll drastically allow me to simplify my pipelines and make them scale.

gegles · 2019-10-19T00:11:25Z

Any update? Can this go through?

jetersen · 2019-10-21T08:10:06Z

@dwnusbaum @bitwiseman @oleg-nenashev should I go ahead and ask for commit access and release permission?

gegles · 2019-10-21T17:07:47Z

@dwnusbaum @bitwiseman @oleg-nenashev any chance you could unblock this? Much appreciated.

henryborchers · 2019-10-23T20:53:42Z

@bitwiseman, do you have any plans on reviewing this?

oleg-nenashev · 2019-10-23T22:39:37Z

@Casz @gegles I do not maintain this repo, but I will pass your ping to @bitwiseman and @dwnusbaum in my company's internal slack

bitwiseman · 2019-10-23T22:42:32Z

Pardon me, I've been head down on #355.

bitwiseman · 2019-10-23T22:48:39Z

@Casz Once again sorry for the delay. This look reasonable. From what I can see the Docker tests are not running (on linux or windows) in CI due to infra issues.

I assume you've tested this manually locally?

jetersen · 2019-10-24T03:33:40Z

Before

13:11:15  [Pipeline] Start of Pipeline
13:11:16  [Pipeline] node
13:11:16  Running on windows_docker-3 in C:/jenkins/workspace/repo_master
13:11:16  [Pipeline] {
13:11:16  [Pipeline] stage
13:11:16  [Pipeline] { (Declarative: Checkout SCM)
13:11:16  [Pipeline] checkout
13:11:19  using credential gitlab_ssh_key
13:11:19  Cloning the remote Git repository
13:11:19  Cloning repository git@git.company.com:Group/repo.git
13:11:19   > git init C:\jenkins\workspace\repo_master # timeout=10
13:11:19  Fetching upstream changes from git@git.company.com:Group/repo.git
13:11:19   > git --version # timeout=10
13:11:19  using GIT_SSH to set credentials SSH key for GitLab
13:11:19   > git fetch --tags --force --progress -- git@git.company.com:Group/repo.git +refs/heads/*:refs/remotes/origin/* # timeout=10
13:11:20   > git config remote.origin.url git@git.company.com:Group/repo.git # timeout=10
13:11:20  Checking out Revision 6977f45ac6693496890b16e8e8912d1789ae8368 (master)
13:11:20  Enabling Git LFS pull
13:11:20   > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
13:11:20   > git config remote.origin.url git@git.company.com:Group/repo.git # timeout=10
13:11:20  Fetching upstream changes from git@git.company.com:Group/repo.git
13:11:20  using GIT_SSH to set credentials SSH key for GitLab
13:11:20   > git fetch --tags --force --progress -- git@git.company.com:Group/repo.git +refs/heads/master:refs/remotes/origin/master # timeout=10
13:11:20   > git config core.sparsecheckout # timeout=10
13:11:20   > git checkout -f 6977f45ac6693496890b16e8e8912d1789ae8368
13:11:20   > git config --get remote.origin.url # timeout=10
13:11:20  using GIT_SSH to set credentials SSH key for GitLab
13:11:20   > git lfs pull origin
13:11:21  Commit message: "indents 😰"
13:11:21   > git rev-list --no-walk 4f1da9f28a4eae8c890f59061b5f6961fe2b253e # timeout=10
13:11:22  [GitLab Pipeline Status] Notifying branch build status: RUNNING Group/repo/master: Build started...
13:11:22  [Pipeline] }
13:11:22  [Pipeline] // stage
13:11:22  [Pipeline] withEnv
13:11:22  [Pipeline] {
13:11:22  [Pipeline] stage
13:11:22  [Pipeline] { (Declarative: Agent Setup)
13:11:23  [Pipeline] isUnix
13:11:23  [Pipeline] readFile
13:11:23  [Pipeline] sh
13:11:23  + docker build -t 6ea565d2baf6a34cf59ae7821dd7571dba6e3e92 -f Dockerfile.CLI .

after

05:28:31  Running on windows in c:/jenkins/workspace/update
05:28:31  [Pipeline] {
05:28:31  [Pipeline] stage
05:28:31  [Pipeline] { (Declarative: Checkout SCM)
05:28:32  [Pipeline] checkout
05:28:37  using credential gitlab_ssh_key
05:28:37  Cloning the remote Git repository
05:28:37  Cloning repository git@git.company.com:Group/repo.git
05:28:37   > git init c:\jenkins\workspace\update # timeout=10
05:28:37  Fetching upstream changes from git@git.company.com:Group/repo.git
05:28:37   > git --version # timeout=10
05:28:37  using GIT_SSH to set credentials SSH key for GitLab
05:28:38   > git fetch --tags --force --progress -- git@git.company.com:Group/repo.git +refs/heads/*:refs/remotes/origin/*
05:28:39   > git config remote.origin.url git@git.company.com:Group/repo.git # timeout=10
05:28:39   > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
05:28:39   > git config remote.origin.url git@git.company.com:Group/repo.git # timeout=10
05:28:39  Fetching upstream changes from git@git.company.com:Group/repo.git
05:28:39  using GIT_SSH to set credentials SSH key for GitLab
05:28:39   > git fetch --tags --force --progress -- git@git.company.com:Group/repo.git +refs/heads/*:refs/remotes/origin/*
05:28:40  Checking out Revision 6977f45ac6693496890b16e8e8912d1789ae8368 (refs/remotes/origin/master)
05:28:40   > git rev-parse "refs/remotes/origin/master^{commit}" # timeout=10
05:28:40   > git rev-parse "refs/remotes/origin/origin/master^{commit}" # timeout=10
05:28:40   > git config core.sparsecheckout # timeout=10
05:28:40   > git checkout -f 6977f45ac6693496890b16e8e8912d1789ae8368
05:28:41  Commit message: "indents 😰"
05:28:41  First time build. Skipping changelog.
05:28:41  [Pipeline] }
05:28:41  [Pipeline] // stage
05:28:41  [Pipeline] withEnv
05:28:41  [Pipeline] {
05:28:41  [Pipeline] stage
05:28:41  [Pipeline] { (Declarative: Agent Setup)
05:28:41  [Pipeline] isUnix
05:28:41  [Pipeline] readFile
05:28:42  [Pipeline] bat
05:28:42  
05:28:42  c:\jenkins\workspace\update>docker build -t f90d1c0c99f7b6b52bdfb6cc8a501fdead79833d -f "Dockerfile.CLI" "."

jetersen · 2019-10-25T12:13:39Z

@bitwiseman I demonstrated your assumption so what are the chances for getting a merge/release? 🤔

jetersen · 2019-10-31T06:47:14Z

@bitwiseman any chance to get this into the 1.3.x branch?

bitwiseman · 2019-11-04T17:38:15Z

@Casz
How about 1.4.0? Doing it now.

jetersen · 2019-11-04T17:45:03Z

That works too @bitwiseman 🥰

allow building dockerfile on Windows

1e7d9f6

jetersen changed the title ~~allow building dockerfile on Windows~~ [JENKINS-47703] - allow building dockerfile on Windows Oct 10, 2019

jetersen mentioned this pull request Oct 10, 2019

Features/windows agents with pathing issues fixed jenkinsci/docker-workflow-plugin#184

Merged

oleg-nenashev requested review from bitwiseman and dwnusbaum October 11, 2019 12:47

oleg-nenashev approved these changes Oct 11, 2019

View reviewed changes

bitwiseman merged commit a411d7e into jenkinsci:master Oct 26, 2019

jetersen deleted the fix/dockerImageBuildWindows branch October 26, 2019 07:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-47703] - allow building dockerfile on Windows #354

[JENKINS-47703] - allow building dockerfile on Windows #354

jetersen commented Oct 10, 2019 •

edited

jetersen commented Oct 10, 2019

oleg-nenashev left a comment

jetersen commented Oct 11, 2019

jetersen commented Oct 16, 2019

henryborchers commented Oct 17, 2019

gegles commented Oct 19, 2019

jetersen commented Oct 21, 2019

gegles commented Oct 21, 2019

henryborchers commented Oct 23, 2019

oleg-nenashev commented Oct 23, 2019

bitwiseman commented Oct 23, 2019

bitwiseman commented Oct 23, 2019

jetersen commented Oct 24, 2019 •

edited

jetersen commented Oct 25, 2019

jetersen commented Oct 31, 2019 •

edited

bitwiseman commented Nov 4, 2019

jetersen commented Nov 4, 2019

[JENKINS-47703] - allow building dockerfile on Windows #354

[JENKINS-47703] - allow building dockerfile on Windows #354

Conversation

jetersen commented Oct 10, 2019 • edited

jetersen commented Oct 10, 2019

oleg-nenashev left a comment

Choose a reason for hiding this comment

jetersen commented Oct 11, 2019

jetersen commented Oct 16, 2019

henryborchers commented Oct 17, 2019

gegles commented Oct 19, 2019

jetersen commented Oct 21, 2019

gegles commented Oct 21, 2019

henryborchers commented Oct 23, 2019

oleg-nenashev commented Oct 23, 2019

bitwiseman commented Oct 23, 2019

bitwiseman commented Oct 23, 2019

jetersen commented Oct 24, 2019 • edited

jetersen commented Oct 25, 2019

jetersen commented Oct 31, 2019 • edited

bitwiseman commented Nov 4, 2019

jetersen commented Nov 4, 2019

jetersen commented Oct 10, 2019 •

edited

jetersen commented Oct 24, 2019 •

edited

jetersen commented Oct 31, 2019 •

edited