Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io.jenkins.plugins:commons-lang3-api #312

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Use io.jenkins.plugins:commons-lang3-api #312

merged 6 commits into from
Apr 28, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 27, 2023

Use io.jenkins.plugins:commons-lang3-api instead of org.apache.commons:commons-lang3.
All tests still pass. I don't think this needs new tests.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@viceice
Copy link
Member Author

viceice commented Apr 27, 2023

uhafner
uhafner reviewed Apr 27, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@viceice @uhafner
remove explicit version
25e3236 
Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
viceice
viceice commented Apr 27, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@viceice viceice requested a review from uhafner April 27, 2023 15:10
uhafner
uhafner approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to fix the root cause for jenkinsci/code-coverage-api-plugin#647.

@olamy
Copy link
Member

olamy commented Apr 27, 2023

LGTM maybe an enforcer rule to ban org.apache.commons:commons-lang3

@viceice
Copy link
Member Author

viceice commented Apr 28, 2023

LGTM maybe an enforcer rule to ban org.apache.commons:commons-lang3

how do I do that? I'm not that familiar with maven

@olamy
Copy link
Member

olamy commented Apr 28, 2023

LGTM maybe an enforcer rule to ban org.apache.commons:commons-lang3

how do I do that? I'm not that familiar with maven

you can look at https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html or

@viceice
Copy link
Member Author

viceice commented Apr 28, 2023

LGTM maybe an enforcer rule to ban org.apache.commons:commons-lang3

@olamy Added, please review

olamy
olamy requested changes Apr 28, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@olamy
Copy link
Member

olamy commented Apr 28, 2023

LGTM maybe an enforcer rule to ban org.apache.commons:commons-lang3

@olamy Added, please review

thanks. I just added a comment.
Then all other PRs will be easier ;)

@olamy olamy added the dependencies Pull requests that update a dependency file label Apr 28, 2023
olamy
olamy requested changes Apr 28, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@viceice viceice requested review from olamy and uhafner April 28, 2023 06:46
@olamy
Copy link
Member

olamy commented Apr 28, 2023

@viceice Great! Thanks for your patience ;)

@olamy olamy merged commit 44da409 into jenkinsci:master Apr 28, 2023
14 checks passed
@viceice viceice deleted the feat/commons-lang3-api branch April 28, 2023 07:54
cpfeiffer pushed a commit to GEBIT/maven-plugin that referenced this pull request May 9, 2023
@viceice @uhafner @cpfeiffer
Use io.jenkins.plugins:commons-lang3-api (jenkinsci#312)
10bc9fb 
* Ban `org.apache.commons:commons-lang3`

---------

Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy Awaiting requested review from olamy

@uhafner uhafner Awaiting requested review from uhafner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
3 participants
@viceice @olamy @uhafner