Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68860] hpi:run does not add Add-Opens directives for Java 17 #507

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jun 21, 2023

Some of the most disgusting code in this repository (copied from Spotless), but I cannot think of a better way to do this.

Testing done

Ran mvn hpi:run in text-finder before and after this PR with Java 17 and a Pipeline job that ran a shell step. Before this PR, got Java module errors; after this PR it worked.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@basil basil added the bug label Jun 21, 2023
@basil basil merged commit 09bd26e into jenkinsci:master Jun 22, 2023
5 checks passed
@basil basil deleted the JENKINS-68860 branch June 22, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants