Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Plugin-Module manifest entry #501

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jun 7, 2023

THe manifest entry was not correctly caclulated, being different depending on where you ran maven from and if you also had any local aggrgator project or not.

The original intention and need of this was to use the path from the git repostory for the PCT, but the code changed from using a git path along the way.

As a result the code produced non deterministic results and the PCT which needed this information has been updated to not need this in jenkinsci/plugin-compat-tester#557

because the information is non deterministic and there are no consumers of this, it is simpler to remove the code.

fixes #497

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

THe manifest entry was not correctly caclulated, being different
depending on where you ran maven from and if you also had any local
aggrgator project or not.

The original intention and need of this was to use the path from the git
repostory for the PCT, but the code changed from using a git path along
the way.

As a result the code produced non deterministic results and the PCT
which needed this information has been updated to not need this in jenkinsci/plugin-compat-tester#557

because the information is non deterministic and there are no consumers
of this, it is simpler to remove the code.
@jtnord jtnord added the removed label Jun 8, 2023
@jtnord jtnord merged commit 32bd070 into jenkinsci:master Jun 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin-Module is calculated incorrectly
2 participants