UI renovation #147

mawinter69 · 2023-07-13T13:54:38Z

use symbols everywhere
use new button style
align things and add gaps

Before:

No gap to border
checkboxes not centered
icons not centered
old style user icon
no gap
old style group icon
no border between permissions
no gap to warning message

After:

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

- use symbols everywhere - use new button style - align cells

on windows the still running jobs likely cause problems with post cleanup due to open file handles

daniel-beck · 2023-07-17T07:05:25Z

Thanks. Screenshots look nice and code on a first read as well.

Is it deliberate that the "trash can" button has a background, and the others don't?

mawinter69 · 2023-07-17T07:23:39Z

The old "x" was also very prominent with it's red color so I thought keep it like that.

daniel-beck · 2023-07-17T07:35:34Z

@mawinter69 That makes sense. WDYT about this, reusing the mas-table__icon-alert?

With the background color also set, it almost looks like a bug. With just the color, it still stands out.

mawinter69 · 2023-07-17T07:41:12Z

agreed with the just the color
btw the blue icons for migration might also not be intended, they come because they're wrapped in a link. Also the select-all unselect-all colors should be changed now to use the currentColor (looks better on dark theme I think).

mawinter69 · 2023-07-17T07:58:18Z

dark theme:

daniel-beck · 2023-07-17T08:34:10Z

FTR "before" colors:

jtnord · 2023-07-19T17:23:21Z

src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.jelly

-      <div class="jenkins-!-margin-top-2">
-        <input type="button" class="matrix-auth-add-button" value="${%Add user…}" id="${id}UserButton"
+      <div class="jenkins-!-margin-top-2 jenkins-buttons-row jenkins-buttons-row--equal-width">
+        <button type="button" class="jenkins-button matrix-auth-add-button" id="${id}UserButton"


causes a regression in the acceptance-test-harness.

StefanSpieker · 2023-07-31T11:55:57Z

This causes a regression on our side:

It tries to download from: https://<JENKINS>/plugin/matrix-auth/images/select-all.svg.
I guess it should be downloaded from somewhere https://<JENKINS>/static/abc1234/...

mawinter69 · 2023-07-31T12:00:00Z

Is this in the AzureAD plugin?

daniel-beck · 2023-07-31T12:00:09Z

@StefanSpieker "Azure User/group to add" should tell you this isn't this plugin. Report a bug in azure-ad.

mawinter69 added 5 commits July 13, 2023 14:35

UI renovation

becdbba

- use symbols everywhere - use new button style - align cells

adjust class names

f0249a7

ensure builds are finished

6e5858f

on windows the still running jobs likely cause problems with post cleanup due to open file handles

fix spotless

2be6d0c

fix class names

b22a307

daniel-beck self-requested a review July 17, 2023 07:03

daniel-beck added 3 commits July 17, 2023 09:28

Set correct icon for internal user/group ambiguous permissions

2e7f027

Semicolon for consistency with other similar messages

24fe7c8

Also adapt tooltips for anonymous and authenticated

166e9f6

mawinter69 added 2 commits July 17, 2023 09:52

make svgs theme aware

df82e44

ensure colors work with all themes nicely

64725dd

daniel-beck mentioned this pull request Jul 17, 2023

Wrap <l:task/> in <l:tasks/> #148

Merged

daniel-beck approved these changes Jul 17, 2023

View reviewed changes

daniel-beck merged commit 23db88f into jenkinsci:master Jul 17, 2023
17 checks passed

basil added a commit to jenkinsci/jenkins that referenced this pull request Jul 17, 2023

Adapt to jenkinsci/matrix-auth-plugin#147

0ed472a

jtnord mentioned this pull request Jul 19, 2023

replace dumpling with a call to jstack jenkinsci/acceptance-test-harness#1285

Merged

jtnord reviewed Jul 19, 2023

View reviewed changes

StefanSpieker mentioned this pull request Jul 31, 2023

Icons select-all and unselect-all are missing when updating matrix-auth-plugin to version 3.1.10 jenkinsci/azure-ad-plugin#448

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI renovation #147

UI renovation #147

mawinter69 commented Jul 13, 2023

Submitter checklist

daniel-beck commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

daniel-beck commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

daniel-beck commented Jul 17, 2023

jtnord Jul 19, 2023

StefanSpieker commented Jul 31, 2023

mawinter69 commented Jul 31, 2023

daniel-beck commented Jul 31, 2023

UI renovation #147

UI renovation #147

Conversation

mawinter69 commented Jul 13, 2023

Testing done

Submitter checklist

daniel-beck commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

daniel-beck commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

mawinter69 commented Jul 17, 2023

daniel-beck commented Jul 17, 2023

jtnord Jul 19, 2023

Choose a reason for hiding this comment

StefanSpieker commented Jul 31, 2023

mawinter69 commented Jul 31, 2023

daniel-beck commented Jul 31, 2023