Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ConcurrentModificationException in free style projects #604

Merged

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Jan 7, 2024

inspired by #558 and partly eliminates
see #503
see #601

The sense of this PR is to split the changes in mentiond PR #558 to make the review (and in worst case revert) much more simple.

note: dissallow white space check to eliminate many many changes produced by code formatting

Testing done

Didn´t creates new testcases. Current test cases shall be enough to validate this changes

Proposed upgrade guidelines

Logger priority in LRM for free-style projects has been changed.

Localizations

There are no UI relevant text.

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • [ x] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • [ ] There is automated testing or an explanation that explains why this change has no tests.
  • New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • [ ] Any localizations are transferred to *.properties files.
  • [ ] Changes in the interface are documented also as examples.

@mPokornyETM mPokornyETM requested a review from a team as a code owner January 7, 2024 22:59
@mPokornyETM mPokornyETM added bug java Pull requests that update Java code parallelism and races ready for review PR is ready for review labels Jan 7, 2024
@mPokornyETM mPokornyETM added this to the Feature committed milestone Jan 7, 2024
@mPokornyETM mPokornyETM removed the ready for review PR is ready for review label Jan 7, 2024
@mPokornyETM mPokornyETM marked this pull request as draft January 7, 2024 23:25
@mPokornyETM mPokornyETM added the ready for review PR is ready for review label Jan 7, 2024
@mPokornyETM mPokornyETM marked this pull request as ready for review January 7, 2024 23:32
@mPokornyETM mPokornyETM added the megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours label Jan 8, 2024
@mPokornyETM mPokornyETM removed the megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours label Jan 11, 2024
@mPokornyETM mPokornyETM merged commit 1b23794 into jenkinsci:master Jan 11, 2024
16 checks passed
@mPokornyETM mPokornyETM deleted the races-in-free-style-projects branch January 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug java Pull requests that update Java code parallelism and races ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants