Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and value of properties are missing on API #600

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

mPokornyETM
Copy link
Contributor

fix #595

Testing done

  • an ephemeral resource 'testing' try to lock reserved resoure 'res1'
  • the resource 'resource-with-properties' has 2 properties

image

Proposed upgrade guidelines

N/A

Localizations

N/N

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • [ ] New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.
    see Name and value of properties are missing on api #595
  • [ ] Any localizations are transferred to *.properties files.
  • Changes in the interface are documented also as examples.
    currently only this PR. We have no documentation for API at themoment.

@mPokornyETM mPokornyETM requested a review from a team as a code owner January 2, 2024 13:57
@mPokornyETM mPokornyETM added bug java Pull requests that update Java code API interactions ready for review PR is ready for review labels Jan 2, 2024
@mPokornyETM mPokornyETM added this to the Feature committed milestone Jan 2, 2024
@mPokornyETM mPokornyETM added the megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours label Jan 4, 2024
@mPokornyETM mPokornyETM added Merged without review ! This PR was marged without reviewers and removed megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours labels Jan 7, 2024
@mPokornyETM mPokornyETM merged commit 5e9500f into jenkinsci:master Jan 7, 2024
16 checks passed
@mPokornyETM mPokornyETM deleted the API-properties branch January 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API interactions bug java Pull requests that update Java code Merged without review ! This PR was marged without reviewers ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name and value of properties are missing on api
1 participant