New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize types #252

Merged

jtnord merged 2 commits into jenkinsci:master from offa:dev

Sep 22, 2023

Contributor

offa commented Sep 22, 2023

Modernize some type related things.

Testing done

Submitter checklist

Beta Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

offa added 2 commits

September 22, 2023 09:31


          Remove unnecessary types

436ce49


          Remove unused imports

887dc77

offa requested a review from a team as a code owner

September 22, 2023 07:51

jtnord approved these changes

View reviewed changes

jtnord added the chore label

jtnord merged commit 4992ea7 into jenkinsci:master

14 checks passed

offa deleted the dev branch

September 24, 2023 17:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment