-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump revision from 6.8.1 to 6.9.2 and test with Java 21 #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional comments for your consideration. Approved whether or not those optional comments are used.
pom.xml
Outdated
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>plugin</artifactId> | |||
<version>4.73</version> | |||
<version>4.74</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most recent release of plugin parent pom
<version>4.74</version> | |
<version>4.76</version> |
pom.xml
Outdated
<changelist>999999-SNAPSHOT</changelist> | ||
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | ||
<jenkins.version>2.401.1</jenkins.version> | ||
<bom>2.401.x</bom> | ||
<bom.version>2378.v3e03930028f2</bom.version> | ||
<bom.version>2507.vcb_18c56b_f57c</bom.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most recent release of bom-2.401.x
<bom.version>2507.vcb_18c56b_f57c</bom.version> | |
<bom.version>2675.v1515e14da_7a_6</bom.version> |
pom.xml
Outdated
@@ -13,12 +13,12 @@ | |||
<version>${revision}-${changelist}</version> | |||
<packaging>hpi</packaging> | |||
<properties> | |||
<revision>6.8.1</revision> | |||
<revision>6.9.0</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most recent release of upstream library. Supersedes pull request
<revision>6.9.0</revision> | |
<revision>6.9.2</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to require Jenkins 2.401.3 instead of 2.401.1.
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Testing done
Confirmed tests pass with Java 21 on Linux.
Supersedes pull request: #229.
Supersedes pull request: #230.
Supersedes pull request: #232.
Submitter checklist
Link to relevant issues in GitHub or Jira