Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump revision from 6.8.1 to 6.9.2 and test with Java 21 #233

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

gounthar
Copy link
Contributor

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21 on Linux.

Supersedes pull request: #229.
Supersedes pull request: #230.
Supersedes pull request: #232.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Copy link
Contributor

@alecharp , @amuniz , or @aneveux could you merge this so that the plugin is regularly tested with Java 21 and Java 17? A new release of the client API plugin seems to also be indicated since the wrapped API jar file has now upgraded to 6.9.2.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional comments for your consideration. Approved whether or not those optional comments are used.

pom.xml Outdated
@@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.73</version>
<version>4.74</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent release of plugin parent pom

Suggested change
<version>4.74</version>
<version>4.76</version>

pom.xml Outdated
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<jenkins.version>2.401.1</jenkins.version>
<bom>2.401.x</bom>
<bom.version>2378.v3e03930028f2</bom.version>
<bom.version>2507.vcb_18c56b_f57c</bom.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent release of bom-2.401.x

Suggested change
<bom.version>2507.vcb_18c56b_f57c</bom.version>
<bom.version>2675.v1515e14da_7a_6</bom.version>

pom.xml Outdated
@@ -13,12 +13,12 @@
<version>${revision}-${changelist}</version>
<packaging>hpi</packaging>
<properties>
<revision>6.8.1</revision>
<revision>6.9.0</revision>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent release of upstream library. Supersedes pull request

Suggested change
<revision>6.9.0</revision>
<revision>6.9.2</revision>

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to require Jenkins 2.401.3 instead of 2.401.1.

pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@amuniz amuniz added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 8, 2024
@amuniz amuniz changed the title Update parent POM, update dependencies, test with Java 21. Bump revision from 6.8.1 to 6.9.2 and test with Java 21 Jan 8, 2024
@amuniz amuniz merged commit e49a3f2 into jenkinsci:master Jan 8, 2024
13 checks passed
@gounthar gounthar deleted the jdk21 branch January 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
3 participants